Fix bug: When using dynamic linking, auth will be loaded repeatedly. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joii2020
commented
Dec 8, 2023
•
joii2020
commented
- ckb-auth-rs: Add features to control dynamic linking and CKBDLContext in static memory
- C language: supports dynamic loading of multiple ckb-auth
- Fix bug: When using dynamic linking, auth will be loaded repeatedly.
- Update tests/README.md
XuJiandong
requested changes
Dec 8, 2023
c/ckb_auth.h
Outdated
| @@ -120,19 +120,24 @@ typedef int (*ckb_auth_validate_t)(uint8_t auth_algorithm_id, | |||
| uint32_t pubkey_hash_size); | |||
|
|
|||
| static uint8_t g_code_buff[300 * 1024] __attribute__((aligned(RISCV_PGSIZE))); | |||
| static void* g_code_handle; | |||
joii2020
changed the title
XuJiandong
requested changes
Dec 13, 2023
| @@ -9,8 +9,14 @@ edition = "2021" | |||
| default = [] | |||
| ckb2023 = ["ckb-std/ckb2023"] | |||
|
|
|||
| enable-dynamic-library = ["lazy_static"] | |||
| dynamic-library-memory-200 = ["enable-dynamic-library"] | |||
There was a problem hiding this comment.
use this feature as default.
| @@ -9,8 +9,14 @@ edition = "2021" | |||
| default = [] | |||
| ckb2023 = ["ckb-std/ckb2023"] | |||
|
|
|||
| enable-dynamic-library = ["lazy_static"] | |||
There was a problem hiding this comment.
use this feature as default
Add more comments
joii2020
changed the title
If defined, dynamic library is disabled.
XuJiandong
requested changes
Dec 15, 2023
Comment on lines
+166
to
+168
| if (buf_offset % RISCV_PGSIZE != 0) { | ||
| buf_offset += RISCV_PGSIZE - buf_offset % RISCV_PGSIZE; | ||
| } |
XuJiandong
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.